[U-Boot] [PATCH] Support for Calao USB A9263 board based on AT91SAM9263 CPU

Reinhard Meyer u-boot at emk-elektronik.de
Fri Aug 20 13:47:05 CEST 2010


Dear Thomas Petazzoni,

I can find no comments or anything for this patch.

> The Calao USB A9263 board is a board manufactured and sold by Calao
> Systems <http://www.calao-systems.com>. Its components are very
> similar to the AT91SAM9263EK board, so its configuration is based
> on the configuration of this board. There are however some
> differences: different clocks, no LCD, etc.
>  MAINTAINERS                       |    4 +
>  MAKEALL                           |    1 +

>  Makefile                          |    3 +

Please change this to use boards.cfg instead.

> +# (C) Copyright 2003-2008
> +# Wolfgang Denk, DENX Software Engineering, wd at denx.de.
> +#
> +# (C) Copyright 2008
> +# Stelian Pop <stelian.pop at leadtechdesign.com>
> +# Lead Tech Design <www.leadtechdesign.com>
> +#
> +# (C) Copyright 2009
> +# Thomas Petazzoni, Free Electrons, <thomas.petazzoni at free-electrons.com>

Not sure, but I think Copyright should be in newest date at the top...

> +#define CONFIG_ATMEL_USART	1
> +#undef CONFIG_USART0
> +#undef CONFIG_USART1
> +#undef CONFIG_USART2
> +#define CONFIG_USART3		1	/* USART 3 is DBGU */

Someone complained earlier in a similiar case that #undefs are not allowed
here, convert this into a comment _IF_ your board can use other USARTs for
console at all. If not drop the #undef lines.

If you would like this patch to go mainstream, please resubmit it and
make sure it will apply to current top-of-tree
.

Best Regards
Reinhard



More information about the U-Boot mailing list