[U-Boot] [PATCH] I2C: Add support for multiple I2C busses for SNTP (effect to RTC)

Wolfgang Denk wd at denx.de
Fri Aug 20 16:05:15 CEST 2010


Dear Stephan Linz,

In message <1282310377-9302-1-git-send-email-linz at li-pro.net> you wrote:
> This patch switches to the desired I2C bus when the SNTP
> network service is called. This can be configured using the
> CONFIG_SYS_RTC_BUS_NUM define.
...
> +#if defined(CONFIG_CMD_DATE)
> +/* FIXME: The i2c dependency should move into the RTC drivers itself. This higher
> + * network layer must not know about hardware specifics!!!!!!! */

Incorrect multiline comment style.  And line too long.


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Extreme feminine beauty is always disturbing.
	-- Spock, "The Cloud Minders", stardate 5818.4


More information about the U-Boot mailing list