[U-Boot] [PATCH] Orion5x: bugfix: window size (mis)calculation

Prafulla Wadaskar prafulla at marvell.com
Thu Aug 26 06:55:24 CEST 2010


 

> -----Original Message-----
> From: u-boot-bounces at lists.denx.de 
> [mailto:u-boot-bounces at lists.denx.de] On Behalf Of Albert Aribaud
> Sent: Tuesday, August 24, 2010 6:58 PM
> To: u-boot at lists.denx.de
> Subject: [U-Boot] [PATCH] Orion5x: bugfix: window size 
> (mis)calculation
> 
> Fix orion5x_winctrl_calcsize() off-by-1 bug which caused mapping
> windows to be cut by half. This afected all windows including NOR
> flash (causing half the flash to be unaccessible) but DRAM was and
> still is fine as its size is determined otherwise.
> 
> Signed-off-by: Albert Aribaud <albert.aribaud at free.fr>
> ---
>  arch/arm/cpu/arm926ejs/orion5x/cpu.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/arm/cpu/arm926ejs/orion5x/cpu.c 
> b/arch/arm/cpu/arm926ejs/orion5x/cpu.c
> index 3740e33..260f88b 100644
> --- a/arch/arm/cpu/arm926ejs/orion5x/cpu.c
> +++ b/arch/arm/cpu/arm926ejs/orion5x/cpu.c
> @@ -61,7 +61,7 @@ unsigned int 
> orion5x_winctrl_calcsize(unsigned int sizeval)
>  	unsigned int j = 0;
>  	u32 val = sizeval >> 1;
>  
> -	for (i = 0; val > 0x10000; i++) {
> +	for (i = 0; val >= 0x10000; i++) {
>  		j |= (1 << i);
>  		val = val >> 1;
>  	}
> -- 

Applied to u-boot-marvell.git master branch

Regards..
Prafulla . .



More information about the U-Boot mailing list