[U-Boot] [PATCH] IDE: Don't assume there are always two devices per bus

[Rogan Dawes]

On 2010/08/16 7:47 AM, Rogan Dawes wrote:
> From: Rogan Dawes <rogan at dawes.za.net>
> 
> Some SATA controllers can operate in an IDE compatible mode (e.g. mvsata)
> but will only ever have a single device per bus.
> 
> This allows the upcoming DNS323 port to properly identify and use
> a drive on both SATA interfaces.
> ---
>  include/ide.h |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/include/ide.h b/include/ide.h
> index 6a1b7ae..c812b28 100644
> --- a/include/ide.h
> +++ b/include/ide.h
> @@ -24,7 +24,8 @@
>  #ifndef	_IDE_H
>  #define _IDE_H
>  
> -#define	IDE_BUS(dev)	(dev >> 1)
> +#define	IDE_BUS(dev)	(dev >> ((CONFIG_SYS_IDE_MAXDEVICE / \
> +				CONFIG_SYS_IDE_MAXBUS) - 1))
>  
>  #define	ATA_CURR_BASE(dev)	(CONFIG_SYS_ATA_BASE_ADDR+ide_bus_offset[IDE_BUS(dev)])
>  

Anything wrong with this patch?

Regards,

Rogan