[U-Boot] [PATCH v2] MTD/SPI/FLASH: add support for Ramtron FRAMs using SPI

Reinhard Meyer u-boot at emk-elektronik.de
Sun Aug 29 00:23:18 CEST 2010


Dear Mike Frysinger,
> On Friday, August 27, 2010 07:16:37 Reinhard Meyer wrote:
>> From: Reinhard Meyer<info at emk-elektronik.de>
>>
>> Signed-off-by: Reinhard Meyer<u-boot at emk-elektronik.de>
>
> looks like you still need to do `git commit --amend --author 'Reinhard Meyer
> <u-boot at emk-elektronik.de>'` ...

Both are valid e-mail addresses, who says the one who signs off and the
one who sends the e-mail must be the same person? Its tedious to change that
because its like 10 commits back in my branch. But I can do that again.

>
>> +#ifdef CONFIG_SPI_FRAM_RAMTRON_NONSTD
>
> i would stick with the style "NON_JEDEC"

Doable.

Is there anything else within the patch itself that you deem need to be
changed?

Reinhard


More information about the U-Boot mailing list