[U-Boot] [PATCH 2/7] Expand POST memory test to support arch-depended implementation.

[sun york-R58495]

Wolfgang,

Without progress indicator, slowe test on memory takes minutes and it looks like hanging. You probably don't want to run it every time the board boots up.

York Sun
----- Original Message -----
From:"Wolfgang Denk" <wd at denx.de>
To:"York Sun" <yorksun at freescale.com>
Cc:"u-boot at lists.denx.de" <u-boot at lists.denx.de>
Sent:8/29/2010 3:56 AM
Subject:Re: [U-Boot] [PATCH 2/7] Expand POST memory test to support arch-depended implementation.


Dear York Sun,

In message <1282944356-4020-2-git-send-email-yorksun at freescale.com> you wrote:
> Add progress indicator for slow test. It is useful when the testing
> takes too longer to finish. The indicator is reused from flash
> programming.
> 
> Hwconfig is used to turn on slow test when not enabled by flag.

NAK.

POST is supposed to be an automatic, unmonitored functionality.
Results are suposed to be reported through a mechanism compatible to
Linux' syslog system.

There is no place for progress indicators here.


Please note that your subject "support arch-depended implementation"
and the commit message "Add progress indicator" are seriously out of
sync as well.  Another reason for a NAK.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Voodoo Programming: Things programmers do that  they  know  shouldn't
work  but they try anyway, and which sometimes actually work, such as
recompiling everything.                             - Karl Lehenbauer