[U-Boot] [PATCH] fix the c_size, in CSD Version 2.0, it's 22 bits

Reinhard Meyer u-boot at emk-elektronik.de
Mon Aug 30 13:08:11 CEST 2010


Xiangfu Liu schrieb:
> Signed-off-by: Xiangfu Liu <xiangfu at openmobilefree.net>
> ---
>  include/mmc.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/include/mmc.h b/include/mmc.h
> index fcb237e..b913a60 100644
> --- a/include/mmc.h
> +++ b/include/mmc.h
> @@ -189,12 +189,12 @@ struct mmc_csd
>  	u8	tran_speed;
>  	u16	ccc:12,
>  		read_bl_len:4;
> +	u32	c_size:22;
>  	u64	read_bl_partial:1,
>  		write_blk_misalign:1,
>  		read_blk_misalign:1,
>  		dsr_imp:1,
>  		rsvd2:2,
> -		c_size:12,
>  		vdd_r_curr_min:3,
>  		vdd_r_curr_max:3,
>  		vdd_w_curr_min:3,

NAK

This structure approach is awfully broken. LE/BE
issues, c_size spans over a 32 bit boundary!

The generic MMC works fine with no such structure.

I already proposed in earlier patches to finally
remove that structure.

Reinhard



More information about the U-Boot mailing list