[U-Boot] [PATCH v3 3/7] [REPOST] add Multi Function Pin configuration support for ARMADA100

Wolfgang Denk wd at denx.de
Thu Dec 2 12:34:45 CET 2010


Dear Lei Wen,

In message <AANLkTimZTFsmL0bzbTi+exRZJKg5JH9kXQZUKeVRcNmV at mail.gmail.com> you wrote:
> Do we really need this? I think the better way to configure GPIO MFP
> is doing like below.
> That is create each GPIO name, and define its MFPD and MFP_AF.
> 
> > +/* UART2 */
> > +#define MFP47_UART2_RXD                MFPD(47) | MFP_AF(6)
> > +#define MFP48_UART2_TXD                MFPD(48) | MFP_AF(6)
> > +#define MFP88_UART2_RXD                MFPD(88) | MFP_AF(2)
...

No. This is exactly what I do not want to see.

We will end up with zillions of #defines, and only a tiny percentage
of them will ever be used.

Please use plain simple tables instead.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
If there are self-made purgatories, then we all have to live in them.
	-- Spock, "This Side of Paradise", stardate 3417.7


More information about the U-Boot mailing list