[U-Boot] [PATCH v3 3/7] [REPOST] add Multi Function Pin configuration support for ARMADA100

[Prafulla Wadaskar]

> -----Original Message-----
> From: Wolfgang Denk [mailto:wd at denx.de]
> Sent: Thursday, December 02, 2010 5:05 PM
> To: Lei Wen
> Cc: Prafulla Wadaskar; Eric Miao; Manas Saksena; Lei Wen; Yu Tang; u-
> boot at lists.denx.de; Ashish Karkare; Kiran Vedere; Prabhanjan Sarnaik
> Subject: Re: [U-Boot] [PATCH v3 3/7] [REPOST] add Multi Function Pin
> configuration support for ARMADA100
> 
> Dear Lei Wen,
> 
> In message <AANLkTimZTFsmL0bzbTi+exRZJKg5JH9kXQZUKeVRcNmV at mail.gmail.com>
> you wrote:
> > Do we really need this? I think the better way to configure GPIO MFP
> > is doing like below.
> > That is create each GPIO name, and define its MFPD and MFP_AF.

There should be no issue defining as MFP_GPIO(16) or MFP16_GPIO, but it saves hundreds of lines in the code.

> >
> > > +/* UART2 */
> > > +#define MFP47_UART2_RXD                MFPD(47) | MFP_AF(6)
> > > +#define MFP48_UART2_TXD                MFPD(48) | MFP_AF(6)
> > > +#define MFP88_UART2_RXD                MFPD(88) | MFP_AF(2)
> ...
> 
> No. This is exactly what I do not want to see.
> 
> We will end up with zillions of #defines, and only a tiny percentage
> of them will ever be used.

I agree with Wolfgang,
On armada168 there are 118 MFPs each can have several programming options,
I have defined few of them which will be generally used.

Regards..
Prafulla ..