[U-Boot] [PATCH] Enable garbage collection of unused input sections.
Wolfgang Denk
wd at denx.de
Sun Dec 5 13:23:14 CET 2010
Dear Luigi 'Comio' Mantellini,
In message <1291545952-26761-2-git-send-email-luigi.mantellini at idf-hit.com> you wrote:
> When available, enable the CC -ffunction-sections/-fdata-sections options and
> the LD --gc-sections in order to isolate and remove from final executable the
> unused functions.
...
> ---
> config.mk | 9 +++++++++
> 1 files changed, 9 insertions(+), 0 deletions(-)
Why do you ignore my previous review comments?
You cannot simply turn this feature on globally for all boards. You
will have to make appropriate adjustments more or less everywhere:
- some architectures already have these options set, so these should
be removed from the architecture / board specific config files
- other architectures have this NOT set, and they need adjustments to
the respective inker scripts.
As is, your patch breaks a zillion of boards.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
To the systems programmer, users and applications serve only to
provide a test load.
More information about the U-Boot
mailing list