[U-Boot] [PATCH] boot cmds: convert to getenv_yesno() with autostart
Wolfgang Denk
wd at denx.de
Tue Dec 7 23:19:38 CET 2010
Dear Mike Frysinger,
In message <201012071657.42065.vapier at gentoo.org> you wrote:
>
> > In addition to the default values, there is the difference that the
> > documentation states that "autostart" has to be set to "yes", i. e. a
> > plain "y" is not supposed to mean 'yes'.
>
> consider it an enhancement then ? i dont see a problem with making the values
> fuzzier. personally, i make funcs like this accept any of the common strings
> such as true/false/0/1/y/n/yes/no.
That should be documented, then. And it should be sensible not to
accept anything. A typo like "yno" should IMHO _not_ be interpreted
as "yes".
> > I think the easiest way to fix this is to revert the commit.
>
> it's in "next", so it could even just be dropped
Yes, but then I have to rebase next...
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"You shouldn't make my toaster angry." - Household security explained
in "Johnny Quest"
More information about the U-Boot
mailing list