[U-Boot] [PATCH] boot cmds: convert to getenv_yesno() with autostart
Mike Frysinger
vapier at gentoo.org
Tue Dec 7 23:32:40 CET 2010
On Tuesday, December 07, 2010 17:19:38 Wolfgang Denk wrote:
> Mike Frysinger wrote:
> > > In addition to the default values, there is the difference that the
> > > documentation states that "autostart" has to be set to "yes", i. e. a
> > > plain "y" is not supposed to mean 'yes'.
> >
> > consider it an enhancement then ? i dont see a problem with making the
> > values fuzzier. personally, i make funcs like this accept any of the
> > common strings such as true/false/0/1/y/n/yes/no.
>
> That should be documented, then. And it should be sensible not to
> accept anything. A typo like "yno" should IMHO _not_ be interpreted
> as "yes".
good point ... i hadnt thought of that
> > > I think the easiest way to fix this is to revert the commit.
> >
> > it's in "next", so it could even just be dropped
>
> Yes, but then I have to rebase next...
imo, keeping the "next" branch clean at the cost of unstableness isnt a
problem. this seems to be the convention that Linux started and other people
follow. personally, when i use "next" from anywhere, the first thing i do is
reset my local "next" branch to whatever the current upstream state.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20101207/6bd7d39b/attachment.pgp
More information about the U-Boot
mailing list