[U-Boot] warning: "CONFIG_SYS_TEXT_BASE" redefined, was Re: [PATCH 1/2] AT91: fix TOP9000 built issues

[Reinhard Meyer]

I wrote:

>  /*
>   * Warning: changing CONFIG_SYS_TEXT_BASE requires
> - * adapting the initial boot program
> + * adapting the initial boot program.
> + * Guard it since the definition finds its way to the command-line and
> + * causes warnings when this file is included
>   */
> -#define CONFIG_SYS_TEXT_BASE		0x21f00000	/* 31 MB into RAM */
> +#ifndef CONFIG_SYS_TEXT_BASE
> +# define CONFIG_SYS_TEXT_BASE		0x21f00000	/* 31 MB into RAM */
> +#endif

Because I had this warning when building u-boot:

*** make u-boot.bin
In file included from /home/reinhard/embedded/top9000/build/u-boot/include/config.h:5,
                 from include/common.h:37:
/home/reinhard/embedded/u-boot-atmel/include/configs/top9000.h:45:1: warning: "CONFIG_SYS_TEXT_BASE" redefined
<command-line>: warning: this is the location of the previous definition

Since I found guarding the define a bit ugly, I removed it again, trying to investigate
where exactly the definition in the command line came from.

Surprisingly, further builds did not ever again show that warning. I can only assume some
stuff in the out-of-tree build was dormant and got removed when I did a "make clean".

A new patch without the guarding will follow soon.

Best Regards,
Reinhard