[U-Boot] [PATCH 1/1] armv7: start.S: Fix relocation address caculation

[Jason Liu]

Hi, Wolfgang,

2010/12/16 Wolfgang Denk <wd at denx.de>:
> Dear Albert ARIBAUD,
>
> In message <4D09E2B9.5030405 at free.fr> you wrote:
>>
>> Why must you modify the original layout?
>
> right!
>
>> Also, what is this 'plug-in' if it is not an IPL?
>
> Yes, and why must it be linked at TEXT_BASE?
>
> Let's stop this here.
>
> Let's wait until any code is submitted or proposed that actually
> needs such a feature.  Then we can discuss the design and try to find
> a solution that makes sense.

In fact, this is indeed one bug in the code as I said in the comit log:

"the _dynsym_start_ofs and _rel_dyn_start_ofs is the
offset from _start, so, need use _start address instead
of _TEXT_BASE to caculate the rel dyn start and sym table
address. This patch also correct the board_init_r function
address caculation in relocation area. The addr of board_init_r
after relocation is: _board_init_r_offs + relocation start address."

Is there any thing wrong with my patch?
The case I met just make the bug show up.


>
> Best regards,
>
> Wolfgang Denk
>
> --
> DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
> History is only a confused heap of facts.
>                                       -- Philip Earl of Chesterfield
>