[U-Boot] [PATCH 1/1] armv7: start.S: Fix relocation address caculation

Wolfgang Denk wd at denx.de
Thu Dec 16 13:20:34 CET 2010


Dear Jason Liu,

In message <AANLkTik=BSaBbV-NOJYg2QXx0Q-YYK4=Ox3iF8dWR5re at mail.gmail.com> you wrote:
> 
> In fact, this is indeed one bug in the code as I said in the comit log:
> 
> "the _dynsym_start_ofs and _rel_dyn_start_ofs is the
> offset from _start, so, need use _start address instead
> of _TEXT_BASE to caculate the rel dyn start and sym table
> address. This patch also correct the board_init_r function
> address caculation in relocation area. The addr of board_init_r
> after relocation is: _board_init_r_offs + relocation start address."

If there are really two different bugs, then please split your patch
into to separate commits, and explain the respective problem in the
commit messages.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
A modem is a baudy house.


More information about the U-Boot mailing list