[U-Boot] [PATCH 5/5] MX5:MX53: add initial support for MX53EVK board

[Wolfgang Denk]

Dear Jason Liu,

In message <1292494665-25674-6-git-send-email-r64343 at freescale.com> you wrote:
> Add initial support for MX53EVK board support.
> FEC, SD/MMC, UART, I2C, have been support.
> 
> Signed-off-by: Jason Liu <r64343 at freescale.com>

The following is in addition to previously made comments:

> --- /dev/null
> +++ b/board/freescale/mx53evk/config.mk

Drop that file.

> +CONFIG_SYS_TEXT_BASE = 0x77800000

This goes to the board config file instead.


> +/* size in bytes reserved for initial data */
> +#define BOARD_LATE_INIT

Seems to be a bogus comment?

> +/*
> + * Hardware drivers
> + */

What exactly are "Hardware drivers" ?   

> +#define CONFIG_SYS_MEMTEST_START       0x70000000
> +#define CONFIG_SYS_MEMTEST_END         0x10000

Please say - has this ever been tested?


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Put your Nose to the Grindstone!
                 -- Amalgamated Plastic Surgeons and Toolmakers, Ltd.