[U-Boot] [PATCH 5/5] MX5:MX53: add initial support for MX53EVK board

[Jason Liu]

Hi, Wolfgang,

2010/12/17 Wolfgang Denk <wd at denx.de>:
> Dear Jason Liu,
>
> In message <1292494665-25674-6-git-send-email-r64343 at freescale.com> you wrote:
>> Add initial support for MX53EVK board support.
>> FEC, SD/MMC, UART, I2C, have been support.
>>
>> Signed-off-by: Jason Liu <r64343 at freescale.com>
>
> The following is in addition to previously made comments:
>
>> --- /dev/null
>> +++ b/board/freescale/mx53evk/config.mk
>
> Drop that file.
>
>> +CONFIG_SYS_TEXT_BASE = 0x77800000
>
> This goes to the board config file instead.

A lot of board support has this file as following,

./board/freescale/m5373evb/config.mk
CONFIG_SYS_TEXT_BASE = 0xFF800000
./board/freescale/m547xevb/config.mk
CONFIG_SYS_TEXT_BASE = 0xffe00000
./board/freescale/m5275evb/config.mk
CONFIG_SYS_TEXT_BASE = 0xFFE00000
./board/freescale/m5282evb/config.mk
CONFIG_SYS_TEXT_BASE = 0xffe00000
./board/freescale/m5249evb/config.mk
CONFIG_SYS_TEXT_BASE = 0xFF800000
./board/freescale/m548xevb/config.mk
./board/freescale/mx31ads/config.mk
CONFIG_SYS_TEXT_BASE = 0xffe00000
./board/freescale/m5271evb/config.mk
CONFIG_SYS_TEXT_BASE = 0x87ec0000
CONFIG_SYS_TEXT_BASE = 0x87f00000
./board/freescale/mx31pdk/config.mk
CONFIG_SYS_TEXT_BASE = 0x97800000
./board/freescale/mx51evk/config.mk

Do you mean that all the new added boards support need drop config.mk
in the future?

>
>
>> +/* size in bytes reserved for initial data */
>> +#define BOARD_LATE_INIT
>
> Seems to be a bogus comment?

Yes, will remove it.


>
>> +/*
>> + * Hardware drivers
>> + */
>
> What exactly are "Hardware drivers" ?

Means uart driver, I will change it.

>
>> +#define CONFIG_SYS_MEMTEST_START       0x70000000
>> +#define CONFIG_SYS_MEMTEST_END         0x10000
>
> Please say - has this ever been tested?

Yes,  tested.

Thanks,

BR,
Jason

>
>
> Best regards,
>
> Wolfgang Denk
>
> --
> DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
> Put your Nose to the Grindstone!
>                 -- Amalgamated Plastic Surgeons and Toolmakers, Ltd.
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
>