[U-Boot] [PATCH] Blackfin: bf525-ucr2: new board port

[Wolfgang Denk]

Dear Mike Frysinger,

In message <201012201436.49709.vapier at gentoo.org> you wrote:
>
> > > as for the cpu selection, obviously that cannot be in any common file
> > > since the cpu variant and silicon rev is about as board specific as you
> > > could possibly get.

I did not ask for moving it into a common file, but into the board
config file.

> > And why cannot it be set in the board config file like every other
> > board doing it?
>
> ive explained in the past why.  one of the reasons why i think config.mk makes 
> more sense is this setting is only used for compilation (build flags).  it
> isnt used directly anywhere in the config.h or related code.  i also find it 
> significantly cleaner than the cpu handling as found in the arm or m68k or ppc 
> ports where copy & pasting swaths of code is the rule.

OK, so this is a "I think it makes more sense" and a "I find it
cleaner".  There was no "cannot", as far as I can tell.

I think it makes a lot of sense to try and move all board specific
configuration settings into a single file (the board config file);
this will, among other things, make it easier to make such settings
accessable through some config tool - assume somebody wants to take
steps toward Kconfig or such.

So please get rid of this config.mk file.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
In accord with UNIX philosophy, Perl gives you enough  rope  to  hang
yourself.              - L. Wall & R. L. Schwartz, _Programming Perl_