[U-Boot] [PATCH] Blackfin: bf525-ucr2: new board port

[Mike Frysinger]

On Monday, December 20, 2010 16:05:20 Wolfgang Denk wrote:
> Mike Frysinger wrote:
> > > And why cannot it be set in the board config file like every other
> > > board doing it?
> > 
> > ive explained in the past why.  one of the reasons why i think config.mk
> > makes more sense is this setting is only used for compilation (build
> > flags).  it isnt used directly anywhere in the config.h or related code.
> >  i also find it significantly cleaner than the cpu handling as found in
> > the arm or m68k or ppc ports where copy & pasting swaths of code is the
> > rule.
> 
> OK, so this is a "I think it makes more sense" and a "I find it
> cleaner".  There was no "cannot", as far as I can tell.

things can be moved back, but it would require ugly hacks in the Blackfin code 
to pull it back out.  if you want to live with the ugly hacks as a trade off 
of getting rid of a few more Blackfin config.mk's (but not all), then that is 
possible.

note that these issues shouldnt hold up merging a board which is working the 
way it should as the other boards.

> I think it makes a lot of sense to try and move all board specific
> configuration settings into a single file (the board config file);
> this will, among other things, make it easier to make such settings
> accessable through some config tool - assume somebody wants to take
> steps toward Kconfig or such.

i dont see how Kconfig would be relevant.  the point of Kconfig is to let 
users configure optional features, not aspects burned into hardware.  letting 
people pick a processor that isnt on the board makes no sense.  linux 
specifically has followed this style -- the way the board is physically wired 
up is in the platform resources, not Kconfig.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20101220/ed1ee832/attachment.pgp