[U-Boot] [PATCH] remove (double) LED initialization in arm920t start.s

Reinhard Meyer u-boot at emk-elektronik.de
Thu Dec 23 14:18:00 CET 2010


Dear Wolfgang Denk,
> Dear Reinhard Meyer,
>
> In message<4D1340BD.2090206 at emk-elektronik.de>  you wrote:
>>
>> We should have one function like "show_status(int status)"
>> with various statuses defined like:
>> LED_STATUS_RESET, _BEFORE_RELOC, _AFTER_RELOC, _SENT_DHCP, _STARTING_KERNEL,
>> _CRASHED, ...
>
> Keep the existing code, and just turn the current set of numbers into
> an enum.

What current code?

1. show_boot_progress() is quite close, but has hundreds of values...
Not sure a enum would be useful there, the values have gaps; rather an
errno.h like implementation makes sense there.

2. the LED current code (in some non-ARM) places
has LED types (BOOT, ...) and LED modes (OFF, BLINK, ON).
That is totally different and quite useless for seven segment and
simple LCDisplays.

Best Regards,
Reinhard


More information about the U-Boot mailing list