[U-Boot] [PATCH] remove (double) LED initialization in arm920t start.s

[Wolfgang Denk]

Dear Reinhard Meyer,

In message <4D134C08.8090609 at emk-elektronik.de> you wrote:
>
> > Keep the existing code, and just turn the current set of numbers into
> > an enum.
> 
> What current code?

I meant the existing show_boot_progress() code.

> 1. show_boot_progress() is quite close, but has hundreds of values...
> Not sure a enum would be useful there, the values have gaps; rather an
> errno.h like implementation makes sense there.

I think it's just an implementation detail wether you use an enum or
#defines here.

> 2. the LED current code (in some non-ARM) places
> has LED types (BOOT, ...) and LED modes (OFF, BLINK, ON).
> That is totally different and quite useless for seven segment and
> simple LCDisplays.

Right.

Note that there is more code when it comes to seven segment and
character based LCD displays - please see doc/README.LED_display,
include/led-display.h, common/cmd_display.c and
drivers/misc/pdsp188x.c on one side, or the highly board specific
display code using the same framework in board/a4m072/a4m072.c on the
other side.


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The main thing is the play itself. I swear that greed for  money  has
nothing  to  do with it, although heaven knows I am sorely in need of
money.                                           - Feodor Dostoyevsky