[U-Boot] [PATCH 3/3] edb93xx: enable the uart in devicecfg register

Matthias Kaehlcke matthias at kaehlcke.net
Sat Feb 6 23:24:02 CET 2010


Hi Alessandro,

El Sat, Feb 06, 2010 at 08:54:05PM +0100 Alessandro Rubini ha dit:

> printf goes to uart1, but it will block forever waiting for
> busy to go off unless the uart is enabled first.
> 
> Signed-off-by: Alessandro Rubini <rubini at gnudd.com>
> ---
>  board/edb93xx/edb93xx.c |    6 ++++++
>  1 files changed, 6 insertions(+), 0 deletions(-)
> 
> diff --git a/board/edb93xx/edb93xx.c b/board/edb93xx/edb93xx.c
> index 4df2246..dde30ff 100644
> --- a/board/edb93xx/edb93xx.c
> +++ b/board/edb93xx/edb93xx.c
> @@ -64,6 +64,12 @@ int board_init(void)
>  	value |= SYSCON_PWRCNT_UART_BAUD;
>  	writel(value, &syscon->pwrcnt);
>  
> +	/* Enable the uart in devicecfg */
> +	value = readl(&syscon->devicecfg);
> +	value |= 1<<18 /* U1EN */;

using a constant like DEVCFG_U1EN would be preferrable, as the patch
is correct at the functional and coding style level i'll leave it to
Tom to decide if we fix this now or later

> +	writel(0xAA, &syscon->sysswlock);
> +	writel(value, &syscon->devicecfg);
> +
>  	/* Machine number, as defined in linux/arch/arm/tools/mach-types */
>  	gd->bd->bi_arch_number = CONFIG_MACH_TYPE;

Acked-by: Matthias Kaehlcke <matthias at kaehlcke.net>

-- 
Matthias Kaehlcke
Embedded Linux Developer
Barcelona

             If liberty means anything at all, it means the
           right to tell people what they do not want to hear
                            (George Orwell)
                                                                 .''`.
    using free software / Debian GNU/Linux | http://debian.org  : :'  :
                                                                `. `'`
gpg --keyserver pgp.mit.edu --recv-keys 47D8E5D4                  `-


More information about the U-Boot mailing list