[U-Boot] [PATCH 3/9] MX51: Add register definitions

[Detlev Zundel]

Hi Stefano,

> The patch add header files to support the Freescale i.MX51
> processor, setting definitions for internal registers.
>
> Signed-off-by: Stefano Babic <sbabic at denx.de>
> Signed-off-by: Fred Fan fanyefeng at gmail.com
> ---
>  include/asm-arm/arch-mx51/crm_regs.h |  182 +++++++++++++++++++++
>  include/asm-arm/arch-mx51/imx-regs.h |  298 ++++++++++++++++++++++++++++++++++
>  2 files changed, 480 insertions(+), 0 deletions(-)
>  create mode 100644 include/asm-arm/arch-mx51/crm_regs.h
>  create mode 100644 include/asm-arm/arch-mx51/imx-regs.h
>
> diff --git a/include/asm-arm/arch-mx51/crm_regs.h b/include/asm-arm/arch-mx51/crm_regs.h
> new file mode 100644
> index 0000000..92da560
> --- /dev/null
> +++ b/include/asm-arm/arch-mx51/crm_regs.h
> @@ -0,0 +1,182 @@
> +/*
> + * Copyright 2009 Freescale Semiconductor, Inc. All Rights Reserved.
> + */
> +
> +/*
> + * The code contained herein is licensed under the GNU General Public
> + * License. You may obtain a copy of the GNU General Public License
> + * Version 2 or later at the following locations:
> + *
> + * http://www.opensource.org/licenses/gpl-license.html
> + * http://www.gnu.org/copyleft/gpl.html
> + */

Again we need to state explicitely the version of the GPL.

> +#ifndef __ARCH_ARM_MACH_MX51_CRM_REGS_H__

> +#define __ARCH_ARM_MACH_MX51_CRM_REGS_H__
> +
> +#define MXC_CCM_BASE	CCM_BASE_ADDR
> +
> +/* DPLL register mapping structure */
> +struct mxc_pll_reg {
> +	unsigned int ctrl;
> +	unsigned int config;
> +	unsigned int op;
> +	unsigned int mfd;
> +	unsigned int mfn;
> +	unsigned int mfn_minus;
> +	unsigned int mfn_plus;
> +	unsigned int hfs_op;
> +	unsigned int hfs_mfd;
> +	unsigned int hfs_mfn;
> +	unsigned int mfn_togc;
> +	unsigned int destat;

Why not use u32 to explicitely state the width?  Same goes for the rest
of the file.

Cheers
  Detlev

-- 
Zivilisation ist der Zaubertrick, der uns unsere wahre Natur verbirgt.
                                            -- Salman Rushdie
--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de