[U-Boot] [RFC] MUSB-UDC issues and fixes

Mike Frysinger vapier at gentoo.org
Mon Jan 11 22:35:35 CET 2010


On Monday 11 January 2010 15:00:40 Juha Kuikka wrote:
> 2. On DM850 the MUSB interrupts are read from a wrapper, not from MUSB
> block . Add optional interface function to read-and-clear interrupts.
>
> +#ifndef CONFIG_MUSB_SOC_IRQ
> +static void musb_get_interrupts(u8 *usb, u16 *rx, u16 *tx)
> +{
> +	*usb = readb(&musbr->intrusb);
> +	*rx = readw(&musbr->intrrx);
> +	*tx = readw(&musbr->intrtx);
> +}
> +#else
> +extern void musb_get_interrupts(u8 *usb, u16 *rx, u16 *tx);
> +#endif

this looks like a static MUSB implementation rather than a config option a 
user/board would control, right ?  so perhaps we should stick with the 
"internal" symbol naming rather than CONFIG_MUSB_xxx ... e.g. the way we're 
handling dynamic fifos and/or multipoint.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20100111/f787f2ae/attachment.pgp 


More information about the U-Boot mailing list