[U-Boot] [PATCH V2 1/9] mkimage: Add Freescale imx Boot Image support (imximage)

[Fabio Estevam]

Hi Stefano,


--- On Wed, 1/13/10, Stefano Babic <sbabic at denx.de> wrote:

> From: Stefano Babic <sbabic at denx.de>
> Subject: [U-Boot] [PATCH V2 1/9] mkimage: Add Freescale imx Boot Image support (imximage)
> To: u-boot at lists.denx.de
> Date: Wednesday, January 13, 2010, 7:50 AM
> This patch adds support for
> "imximage" (MX Boot Image)
> to the mkimage utility. The imximage is used on the
> Freescales's
> MX.51 processors.

I like the way you handle the internal boot on the MX51. Very smart approach ;-)

MX25 and MX35 can also benefit from the imximage utility that you proposed, so please change the description to make it more generic, such as:

"The imximage can be used on MX25, MX35 and MX51 processors for handling internal boot mode." 


....

> +---------------------------------------------
> +Imximage Boot Image generation using mkimage
> +---------------------------------------------
> +
> +This document describes how to set up a U-Boot image
> +that can be booted by the Freescale i.MX51 processor.

You could write: "... that can be booted by Freescale MX25, MX35 and MX51 processors via internal boot mode" 

...

> +#define MAX_HW_CFG_SIZE 60    /* Max number
> of registers imx.51 can set */

MX25, MX35, MX51 can set

...

> +    /* Init Freescale imx.51 Boot image
> generation/list support */

MX25, MX35 and MX51 Boot image ...

Regards,

Fabio Estevam