[U-Boot] [PATCH 9/9] Add support for KARO TX25 board

[Wolfgang Denk]

Dear John Rigby,

In message <1263357841-5100-10-git-send-email-jcrigby at gmail.com> you wrote:
> This is an i.MX25 base board with only NAND
> so it uses nand_spl to boot.
> 
> Signed-off-by: John Rigby <jcrigby at gmail.com>
> 
> Tune configuration, add support for (redundant) environment in NAND.
> Signed-off-by: Wolfgang Denk <wd at denx.de>

This contains some test code that should be removed:

> diff --git a/board/karo/tx25/tx25.c b/board/karo/tx25/tx25.c
> new file mode 100644
> index 0000000..51482ae
> --- /dev/null
> +++ b/board/karo/tx25/tx25.c
...
> +void tx25_fec_init(void)
> +{
> +	struct iomuxc_mux_ctl *muxctl;
> +	struct iomuxc_pad_ctl *padctl;
> +	u32 val;
> +	u32 gpio_mux_mode = MX25_PIN_MUX_MODE(5);
> +	struct gpio_regs *gpio4 = (struct gpio_regs *)IMX_GPIO4_BASE;
> +	struct gpio_regs *gpio3 = (struct gpio_regs *)IMX_GPIO3_BASE;
> +	u32 saved_rdata0_mode, saved_rdata1_mode, saved_rx_dv_mode;
> +
> +	printf("tx25_fec_init\n");

Make this debug(), please.

> +	/* drop PHY power and assert reset (low) */
> +	val = readl(&gpio4->dr) & ~((1 << 7) | (1 << 9));
> +	writel(val, &gpio4->dr);
> +	val = readl(&gpio4->dir) | (1 << 7) | (1 << 9);
> +	writel(val, &gpio4->dir);
> +
> +	mdelay(5);
> +
> +	printf("resetting phy\n");

And this, too.



Except for these two changes:

Acked-by: Wolfgang Denk <wd at denx.de>

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"...one of the main causes of the fall of the Roman Empire was  that,
lacking  zero,  they had no way to indicate successful termination of
their C programs."                                     - Robert Firth