[U-Boot] [PATCH v2] Make getenv_IPaddr() global

Wolfgang Denk wd at denx.de
Sun Jan 17 20:15:00 CET 2010


Dear Dirk Behme,

In message <1262504038-21479-1-git-send-email-dirk.behme at googlemail.com> you wrote:
> There are boards out there that do not have network support in
> U-Boot (CONFIG_CMD_NET not set), but they do so in Linux. This
> makes it desirable to be able to port network configuration (like
> the IP address) to the Linux kernel.
> 
> We should not make the passing of the IP configuration to Linux
> dependent on U-Boot features / settings.
> 
> For this, make getenv_IPaddr() global. This fixes build error
> 
> u-boot/lib_xxx/board.c:360: undefined reference to `getenv_IPaddr'
> 
> on various architectures.
> 
> Signed-off-by: Dirk Behme <dirk.behme at googlemail.com>
> 
> ---
> 
> Changes in v2:
> 
> - Move getenv_IPaddr() to common header file and make it static inline
> 
> This makes other patches trying to fix this issue obsolete. E.g.
> 
> http://lists.denx.de/pipermail/u-boot/2009-December/065809.html
> http://lists.denx.de/pipermail/u-boot/2009-December/065810.html
> http://lists.denx.de/pipermail/u-boot/2009-December/065822.html
> 
> See
> 
> http://lists.denx.de/pipermail/u-boot/2009-December/065833.html
> http://lists.denx.de/pipermail/u-boot/2009-December/065847.html
> http://lists.denx.de/pipermail/u-boot/2009-December/065848.html
> 
> for further details.
> 
>  include/common.h        |    7 ++++++
>  include/net.h           |    3 --
>  lib_generic/Makefile    |    1 
>  lib_generic/net_utils.c |   50 ++++++++++++++++++++++++++++++++++++++++++++++++
>  net/net.c               |   26 ------------------------
>  5 files changed, 58 insertions(+), 29 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The only person who always got his work done by Friday
                                                 was Robinson Crusoe.


More information about the U-Boot mailing list