[U-Boot] [PATCH v3] add ASTRO MCF5373L board

[Wolfgang Denk]

Dear Wolfgang Wegner,

In message <1263231799-28685-1-git-send-email-w.wegner at astro-kom.de> you wrote:
> This patch adds support for ASTRO board(s) based on MCF5373L.
> 
> Signed-off-by: Wolfgang Wegner <w.wegner at astro-kom.de>
...
> +	/* GPIO configuration for bus should be set correctly from reset,
> +	 * so we do not care! First, set up address space: at this point,
> +	 * we should be running from internal SRAM;
> +	 * so use CONFIG_SYS_SDRAM_BASE as the base address for SDRAM,
> +	 * and do not care where it is
> +	 */

Incorrect multiline comment style.

> +	/* I am not sure from the data sheet, but it seems burst length
> +	 * has to be 8 for the 16 bit data bus we use;
> +	 * so these values are for BL = 8
> +	 */

This happens in a number or places, please fix globally.

> +/*-----------------------------------------------------------------------
> + * UART update subcommand codes
> + */

These, too, please.

> +		/*****************************************
> +		 **	Flash program routine		**
> +		 **	only called in flash mode	**
> +		 *****************************************
> +		 */

And these as well.

> +/*
> + *-----------------------------------------------------------------------------
> + * End of user parameters to be customized
> + *-----------------------------------------------------------------------------
> + */
> +
> +/* ---
> + * Defines memory range for test
> + * ---
> + */

...and these.

Amazing haw many different comment styles you are using in a single
patch. Guess you can apply for a record ;-)


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
1000 pains                                              = 1 Megahertz