[U-Boot] arm: suen3, suen3_v1, mgcoge2_arm_p1a support

[Stefan Roese]

Hi Heiko,

On Monday 18 January 2010 09:34:08 Heiko Schocher wrote:
> >> +#if 1 // test-only cramfs ...
> >> +#define CONFIG_SYS_MAX_FLASH_SECT	256
> >
> > Please do not add dead code (the "#if 1" here),
> > and do not use C++ comments (please fix this globally).
> 
> Ups, sorry.
> 
> >> +#ifndef __ASSEMBLY__
> >> +typedef struct {
> >> +	unsigned long size;			/* total bank size in bytes		
*/
> >> +	unsigned short sector_count;		/* number of erase units		
*/
> >> +	unsigned long flash_id;			/* combined device & manufacturer 
code	*/
> >> +	unsigned long start[CONFIG_SYS_MAX_FLASH_SECT];   /* virtual sector
> >> start address */ +	unsigned char protect[CONFIG_SYS_MAX_FLASH_SECT]; /*
> >> sector protection status	*/ +} flash_info_t;
> >
> > Lines way too long. Please fix globally.
> >
> > Umm.. why cannot you use the struct flash_info_t as declared in
> > "include/flash.h" ??
> 
> Hmm.. I take a look at this point... Stefan? Maybe, you can help here,
> because this comes from your original port, I think.

IIRC, then this was part of the cramfs support provided by Keymile. Sorry, but 
I don't have a better patch available right now. Please let me know if I 
should investigate here further.

Cheers,
Stefan

--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de