[U-Boot] [PATCH v5 08/12] SPEAr : Support for HW mac id read/write from i2c mem

Tom Tom.Rix at windriver.com
Mon Jan 18 13:59:32 CET 2010


Vipin KUMAR wrote:
> On 1/18/2010 12:49 PM, Ben Warren wrote:
>>>>>  
>>>>>          if (chip->cpufreq == -1)
>>>>> @@ -156,6 +215,13 @@ int do_chip_config(cmd_tbl_t *cmdtp, int flag,
>>>>> int argc, char *argv[])
>>>>>          else
>>>>>              printf("DDR Type    = Not Known\n");
>>>>>  
>>>>> +        if (!i2c_read_mac(mac)) {
>>>>> +            sprintf(i2c_mac, "%pM", mac);
>>>>> +            printf("Ethaddr (from i2c mem) = %s\n", i2c_mac);
>>>>>         
>>>> Maybe I'm missing some context, but why's the sprintf needed?
>>>>     
>>> Yes, sprintf is not needed here
>>> Thanks for pointing out
>>>
> 
> Hello Tom,
> Should I send the whole patch set again or only the subpatch after 
> removing the sprintf

Let us wait for feed back from nand and usb subsystem so we
can a accumulate them in just one patch set.

Tom

> 
> Regards
> Vipin



More information about the U-Boot mailing list