[U-Boot] [PATCH 1/2] NAND Nomadik: add CONFIG_NAND_NOMADIK_16BIT option
Wolfgang Denk
wd at denx.de
Tue Jan 19 00:26:55 CET 2010
Dear Alessandro Rubini,
In message <a14c1bde15838a59c60e177a43a4ebd35f28adea.1263851321.git.rubini at unipv.it> you wrote:
>
> Signed-off-by: Alessandro Rubini <rubini at gnudd.com>
> Cc: Gregory Hermant <gregory.hermant at calao-systems.com>
> ---
> drivers/mtd/nand/nomadik.c | 15 +++++++++++----
> 1 files changed, 11 insertions(+), 4 deletions(-)
New config options should be documented. If not in the REDME, so at
last in the commit message. You may know what
CONFIG_NAND_NOMADIK_16BIT is supposed to mean, others may not.
Also, I suggest to change the name into CONFIG_NOMADIK_NAND_16BIT
which seems more logical to me.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"There is no statute of limitations on stupidity."
- Randomly produced by a computer program called Markov3.
More information about the U-Boot
mailing list