[U-Boot] [PATCH 2/2] Add Nomadik board "usb-s8815" by Calao vendor

Alessandro Rubini rubini-list at gnudd.com
Tue Jan 19 00:54:34 CET 2010


[I'm re-adding Gregory Hermant in Cc:, while my message had the Cc:
explicit, the copy I got from the list and your reply had no such header]

> I don't like to see such heavy copying of code.

I understand your point of view (although I didn't use
--find-copies-harder you probably wouldn't have noticed).

However, these are really different boards from different vendors.
The Calao one is a stripped-down version of the development system,
not uncommon to what happens elsewhere.

Where do you suggest to place common code?

While it is true that, currently, platform.S can be placed in common
nomadik code, the file could as well be cleaned up of unneeded or
redundant stuff, which is different in the two boards. (The file is
something I got from the vendor and would benefit from some cleanup,
now that I know more of the various register sets in the SoC).

> Note that many of the existing diffrences can be avoided easily and
> without need for #ifdef's:

You are right. But one LCD needs a turn-on-backlight method, while the
other does not.  If I place it on cpu/arm926ejs/nomadik/ we'll have
problems when another board mounts a different display.

I'll try to factorize as I can, but I'm not sure it's the right thing
to do. Will respin the patch by tomorrow night.

/alessandro


More information about the U-Boot mailing list