[U-Boot] [PATCH 3/3] Add support for EDB93xx boards

[Wolfgang Denk]

Dear Matthias Kaehlcke,

In message <20100119191627.GM16182 at darwin> you wrote:
> Added support for the following EDB93xx boards:
> 
> EDB9301
> EDB9302
> EDB9302A
> EDB9307
> EDB9307A
> EDB93012
> EDB9315
> EDB9315A
...
> +int board_init(void)
> +{
> +	DECLARE_GLOBAL_DATA_PTR;

This is bound to fail. DECLARE_GLOBAL_DATA_PTR must be on file level,
never at function level! Fix globally!

> +	/* Machine number, as defined in linux/arch/arm/tools/mach-types */
> +	gd->bd->bi_arch_number = MACH_TYPE;

Please use CONFIG_MACH_TYPE instead (fix globally).

...
> +	/* copy exception vectors */
> +	src = (unsigned int *)_armboot_start;
> +
> +	for (i = 0; i < 16; i++)
> +		*dst++ = *src++;

Any reason for not using memcpy() ?

> diff --git a/include/configs/edb93xx.h b/include/configs/edb93xx.h
> new file mode 100644
> index 0000000..457dbb2
> --- /dev/null
> +++ b/include/configs/edb93xx.h
> @@ -0,0 +1,273 @@
> +/*
> + */

Please add valid file header.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Doubt is a pain too lonely to know that faith is his twin brother.
- Kahlil Gibran