[U-Boot] [PATCH-V2 4/9] Nand mxc_nand add v1.1 controller support

[Magnus Lilja]

Scott,

Scott Wood skrev:
> On Sat, Jan 16, 2010 at 09:50:22PM -0700, John Rigby wrote:
>> Add support for version 1.1 of the nfc nand flash
>> controller which is on the i.mx25 soc.
>>
>> Use CONFIG_NAND_MXC_V1 and CONFIG_NAND_MXC_V1_1 to
>> differentiate between the two supported versions.
>>
>> Add a define CONFIG_NAND_MXC_V1 to imx27lite board config.
>>
>> Also factor out some soc specific nand geometry config
>> into a new inline routine and a couple of defines:
>>     mxc_get_nfc_info
>>     IMX_NFC_IS_16BIT
>>     IMX_NFC_IS_2KPAGE
>>
>> Added to imx-regs.h.
>>
>> Signed-off-by: John Rigby <jcrigby at gmail.com>
>> Earlier-version-signed-off-by: Wolfgang Denk <wd at denx.de>
>> CC: Scott Wood <scottwood at freescale.com>
>> CC: Fred Fan <fanyefeng at gmail.com>
>> ---
> 
> The 16-bit detection conflicts with
> http://lists.denx.de/pipermail/u-boot/2009-November/064139.html
> 
> Which way should I resolve the conflict?  Or does one of you want to respin?
> I don't see 16BIT/2KPAGE/get_nfc_info defined for MX31... and does MX25
> share MX27's imx-regs.h?
> 
> Magnus, can you test this patch on MX31?

I've now tested the patch and after adding an imx-regs.h for MX31 with the needed information the patch seems to work on i.MX31. Tested on the Litekit board with a small page NAND mounted.


A comment for John Rigby on the patch though: Is it really necessary to specify the version of the NAND controller in the board configuration file? As far as I know, once you select which i.MX-device to use U-boot already has the necessary information to derive the version of the NAND FC automatically.

Regards, Magnus