[U-Boot] [PATCH] smc91111_eeprom: fix linking error

Ben Warren biggerbadderben at gmail.com
Thu Jan 21 22:27:55 CET 2010


Mike,

Mike Frysinger wrote:
> Building for a bf533-stamp ends up with this error:
> smc91111_eeprom.o: In function `smc91111_eeprom':
> examples/standalone/smc91111_eeprom.c:58: undefined reference to `memset'
> make[2]: *** [smc91111_eeprom] Error 1
>
> The new eth_struct definition means gcc has to zero out the structure on
> the stack, and some gcc versions optimize this with an implicit call to
> memset.  So tweak the structure style to avoid that gcc feature.
>
> Signed-off-by: Mike Frysinger <vapier at gentoo.org>
> ---
>  examples/standalone/smc91111_eeprom.c |    5 ++---
>  1 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/examples/standalone/smc91111_eeprom.c b/examples/standalone/smc91111_eeprom.c
> index 9145763..b91f34c 100644
> --- a/examples/standalone/smc91111_eeprom.c
> +++ b/examples/standalone/smc91111_eeprom.c
> @@ -53,9 +53,8 @@ int smc91111_eeprom (int argc, char *argv[])
>  	int c, i, j, done, line, reg, value, start, what;
>  	char input[50];
>  
> -	struct eth_device dev = {
> -		.iobase = CONFIG_SMC91111_BASE
> -	};
> +	struct eth_device dev;
> +	dev.iobase = CONFIG_SMC91111_BASE;
>  
>  	/* Print the ABI version */
>  	app_startup (argv);
>   
Applied to net repo.

thanks,
Ben


More information about the U-Boot mailing list