[U-Boot] [PATCH v2] SPI: Fix 32 bit transfers in mxc_spi.c

Magnus Lilja lilja.magnus at gmail.com
Sat Jan 23 18:08:28 CET 2010


Dear Feng and Tom,

Is this in a queue somewhere to be merged? If not, could you please apply this and make a pull request for it?

Bset regards, Magnus Lilja

Wolfgang Denk skrev:
> Dear Feng,
> 
> can you please take care of this?
> 
> In message <1263726375-4929-1-git-send-email-lilja.magnus at gmail.com> Magnus Lilja wrote:
>> Commit f9b6a1575d9f1ca192e4cb60e547aa66f08baa3f,  "i.MX31: fix SPI
>> driver for shorter than 32 bit" broke 32 bit transfers. This patch
>> makes single 32 bit transfer work again.
>>
>> Transfer lengths that are known not to work will abort and print
>> an error message.
>>
>> Tested on i.MX31 Litekit and i.MX31 PDK using 32 bit transfers to
>> the MC13783/ATLAS chip (using the 'date' command).
>>
>> Signed-off-by: Magnus Lilja <lilja.magnus at gmail.com>
>> ---
>>
>> As discussed on the mailing list, Guennadi Liakhovetski thinks that
>> all transfers > 16 bits are broken. This patch fixes the 32 bit case
>> and makes sure the user is notified if a broken bitlength is used.
>>
>>  drivers/spi/mxc_spi.c |    9 +++++++++
>>  1 files changed, 9 insertions(+), 0 deletions(-)
> 
> Acked-by: Wolfgang Denk <wd at denx.de>
> 
> Best regards,
> 
> Wolfgang Denk
> 



More information about the U-Boot mailing list