[U-Boot] [PATCH 00/12] net: Fix return values of xxx_initialize()
Wolfgang Denk
wd at denx.de
Sun Jan 24 15:23:51 CET 2010
Dear Matthias Kaehlcke,
In message <20100124100708.GF18402 at darwin> you wrote:
> Fix network drivers that don't return the number of initialized
> devices upon successful initialization and 0 in case of failure
>
> Matthias Kaehlcke (12):
> 4xx_enet: Fix return value of ppc_4xx_eth_initialize()
> bfin_EMAC: Fix return value of bfin_EMAC_initialize()
> dnet: Fix return value of dnet_eth_initialize()
> fec_mxc: Fix return values of fec_probe()
> fsl_mcdmafec: Fix return value of mcdmafec_initialize()
> INCA IP: Fix return value of inca_switch_initialize()
> lan91c96: Fix return value of lan91c96_initialize()
> macb: Fix return values of macb_eth_initialize()
> mcffec: Fix return value of mcffec_initialize()
> plb2800: Fix return values of plb2800_eth_initialize()
> sh_eth: Fix return value of sh_eth_initialize()
> smc91111: Fix return value of smc91111_initialize()
...
> 12 files changed, 17 insertions(+), 17 deletions(-)
Why did you split this into 12 commits? It is one logical change, and
should be applied in a single clommit.
Ben, if you should accept this stuff, then please squash all these 12
patches into a single commit.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
I have yet to add the ESP-driver to the kernel to read the mind of
the user... - Linus Torvalds in
<Pine.LNX.3.91.960426110644.24860I-100000 at linux.cs.Helsinki.FI>
More information about the U-Boot
mailing list