[U-Boot] [PATCH 00/12] net: Fix return values of xxx_initialize()

Matthias Kaehlcke matthias at kaehlcke.net
Sun Jan 24 18:18:52 CET 2010


El Sun, Jan 24, 2010 at 09:17:16AM -0800 Ben Warren ha dit:

>    Hi Matthias,
> 
>    On Sun, Jan 24, 2010 at 2:07 AM, Matthias Kaehlcke <matthias at kaehlcke.net>
>    wrote:
> 
>      Fix network drivers that don't return the number of initialized
>      devices upon successful initialization and 0 in case of failure
> 
>      Matthias Kaehlcke (12):
>       4xx_enet: Fix return value of ppc_4xx_eth_initialize()
>       bfin_EMAC: Fix return value of bfin_EMAC_initialize()
>       dnet: Fix return value of dnet_eth_initialize()
>       fec_mxc: Fix return values of fec_probe()
>       fsl_mcdmafec: Fix return value of mcdmafec_initialize()
>       INCA IP: Fix return value of inca_switch_initialize()
>       lan91c96: Fix return value of lan91c96_initialize()
>       macb: Fix return values of macb_eth_initialize()
>       mcffec: Fix return value of mcffec_initialize()
>       plb2800: Fix return values of plb2800_eth_initialize()
>       sh_eth: Fix return value of sh_eth_initialize()
>       smc91111: Fix return value of smc91111_initialize()
> 
>       drivers/net/4xx_enet.c     |    2 +-
>       drivers/net/bfin_mac.c     |    2 +-
>       drivers/net/dnet.c         |    2 +-
>       drivers/net/fec_mxc.c      |    4 ++--
>       drivers/net/fsl_mcdmafec.c |    2 +-
>       drivers/net/inca-ip_sw.c   |    2 +-
>       drivers/net/lan91c96.c     |    2 +-
>       drivers/net/macb.c         |    4 ++--
>       drivers/net/mcffec.c       |    2 +-
>       drivers/net/plb2800_eth.c  |    4 ++--
>       drivers/net/sh_eth.c       |    6 +++---
>       drivers/net/smc91111.c     |    2 +-
>       12 files changed, 17 insertions(+), 17 deletions(-)
> 
>    I appreciate your enthusiasm, but don't see the point of changing all
>    return codes to the current state, when I recently mentioned that the
>    current state is confusing.  Things have been this way for some time, so
>    there's no urgency to fix up all existing drivers.  Hopefully tonight I'll
>    get to the core changes, then we can fix up all drivers at once to a more
>    'final' state.

ok

-- 
Matthias Kaehlcke
Embedded Linux Developer
Barcelona

              Insanity: doing the same thing over and over
                again and expecting different results
                            (Albert Einstein)
                                                                 .''`.
    using free software / Debian GNU/Linux | http://debian.org  : :'  :
                                                                `. `'`
gpg --keyserver pgp.mit.edu --recv-keys 47D8E5D4                  `-


More information about the U-Boot mailing list