[U-Boot] [PATCH] musb: Add host support for DM365 EVM

[Srinivas, Prathap]

Remy,
Please let me know if there are any further comments on this patch.

Thanks,
Prathap.

-----Original Message-----
From: u-boot-bounces at lists.denx.de [mailto:u-boot-bounces at lists.denx.de] On Behalf Of Srinivas, Prathap
Sent: Wednesday, January 20, 2010 10:35 AM
To: Remy Bohmer
Cc: u-boot at lists.denx.de
Subject: Re: [U-Boot] [PATCH] musb: Add host support for DM365 EVM

Remi,
I have fixed your comments and updated the patch.
Please let me know if there are any further comments on this?

Thanks,
Prathap.

-----Original Message-----
From: l.pinguin at gmail.com [mailto:l.pinguin at gmail.com] On Behalf Of Remy Bohmer
Sent: Monday, January 11, 2010 2:02 PM
To: Srinivas, Prathap
Cc: u-boot at lists.denx.de
Subject: Re: [PATCH] musb: Add host support for DM365 EVM

Hi,

>> @@ -41,10 +42,24 @@ struct davinci_usb_regs *dregs;
>>  static u8 phy_on(void)
>>  {
>>        u32 timeout;
>> +       u32 val;
>
> This variable is only used when  DAVINCI_DM365EVM is set, so it will
> produce a warning if it is not set.
>
> <MSP> - We could either initialize the variable or guard its declaration with the DAVINCI_DM365EVM macro. Please let me know what is preferred so that I could update accordingly.

Initialise it will leave it unused as well, so I guess to use the macro.

Remy
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot