[U-Boot] [PATCH RFC 0/2] dcache on ARM
Armando VISCONTI
armando.visconti at st.com
Tue Jan 26 18:59:14 CET 2010
>
>> I don't see the flush_cache() call inside cmd_bootm.c.
>> Don't you think it is necessary before jumping to Linux?
>>
>
> Yes, definitely. Actually, I checked it, but re-checking now I see
> I've been tricked by '[id]cache_disable' being grepped successfully in
> common/cmd_bootm.c . However, it's inside a false ifdef.
>
> I'm booting through the network, so that's probably why it works
> reliably for me (netboot_common does the propre flushing).
>
Right, cache_disable() should be called to do the proper
job, i.e. cache disabling and flushing.
OK, we can wait for more comments but if there are no other architectural
drawbacks I can't think of I'm willing to test it on
SPEAr achitecture as well. Actually I have always thought about
enabling dcache, but too lazy to implement/verify it :-(
Thx,
Arm
--
-- "Every step appears to be the unavoidable consequence of the
-- preceding one." (A. Einstein)
--
Armando Visconti Mobile: (+39) 346 8879146
Senior SW Engineer Fax: (+39) 02 93519290
CPG Work: (+39) 02 93519683
Computer System Division e-mail: armando.visconti at st.com
ST Microelectronics TINA: 051 4683
More information about the U-Boot
mailing list