[U-Boot] [PATCH v2] tsec: do not print Speed: if using netconsole

Ed Swarthout Ed.Swarthout at freescale.com
Thu Jan 28 23:38:52 CET 2010


CONFIG_NETCONSOLE on the p2020ds is functional with the tsec driver.  
But the printf in adjust_link() which is called by startup_tsec()
called by tsec_init() in tsec.c is making it impossible to use.

For example typing 12345 on the netconsole causes the message to be
printed for every character:

=> Speed: 1000, full duplex
1Speed: 1000, full duplex
2Speed: 1000, full duplex
3Speed: 1000, full duplex
4Speed: 1000, full duplex
5Speed: 1000, full duplex

Signed-off-by: Ed Swarthout <Ed.Swarthout at freescale.com>
---

Based on a suggestion from Peter Tyser, check env and only disable if
currently using netconsole.

 drivers/net/tsec.c |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/net/tsec.c b/drivers/net/tsec.c
index d8b6619..42083de 100644
--- a/drivers/net/tsec.c
+++ b/drivers/net/tsec.c
@@ -847,8 +847,10 @@ static void adjust_link(struct eth_device *dev)
 			break;
 		}
 
-		printf("Speed: %d, %s duplex\n", priv->speed,
-		       (priv->duplexity) ? "full" : "half");
+		if (strcmp(getenv("stdin"), "nc") != 0) {
+			printf("Speed: %d, %s duplex\n", priv->speed,
+			       (priv->duplexity) ? "full" : "half");
+		}
 
 	} else {
 		printf("%s: No link.\n", dev->name);
-- 
1.6.5



More information about the U-Boot mailing list