[U-Boot] [PATCH V2 3/3] edmini: add IDE support

[Prafulla Wadaskar]

> -----Original Message-----
> From: Albert ARIBAUD [mailto:albert.aribaud at free.fr] 
> Sent: Wednesday, July 07, 2010 4:20 PM
> To: Prafulla Wadaskar
> Cc: u-boot at lists.denx.de
> Subject: Re: [U-Boot] [PATCH V2 3/3] edmini: add IDE support
> 
> Le 07/07/2010 10:38, Prafulla Wadaskar a écrit :
> 
> > don't you think it is better to add separate driver for 
> Orion/Kirkwood/Marvell
> > SATAC so that this code and even some configurations can be 
> shared by other boards.
> 
> If you mean 'why use cmd_ide rather than the Marvell sata driver also 
> posted recently', I have expressed my opinion there: 
> <http://article.gmane.org/gmane.comp.boot-loaders.u-boot/80702>.
> 
> If you mean 'why not make this a standalone driver, e.g. 
> driver/net/mvsata_ide.{ch} under a configuration option 
> CONFIG_MVSATA_IDE' -- why not, but it would basically be empty of 
> 'driving' functionality (this is handled by cmd_ide) and would only 
> provide initialization code, subject to board options (e.g. 
> CONFIG_MVSATA_IDE_ENABLE_PORT{0,1}).

then you should add below initialization code in cpu.c for respective SoCs
and function call here

Regards..
Prafulla . .