[U-Boot] [PATCH V2 3/3] edmini: add IDE support

[Albert ARIBAUD]

Le 08/07/2010 08:01, Prafulla Wadaskar a écrit :
>
>
>> -----Original Message-----
>> From: Albert ARIBAUD [mailto:albert.aribaud at free.fr]
>> Sent: Wednesday, July 07, 2010 7:39 PM
>> To: Prafulla Wadaskar
>> Cc: u-boot at lists.denx.de
>> Subject: Re: [U-Boot] [PATCH V2 3/3] edmini: add IDE support
>>
>> Le 07/07/2010 13:46, Prafulla Wadaskar a écrit :
>>
>>>> If you mean 'why not make this a standalone driver, e.g.
>>>> driver/net/mvsata_ide.{ch} under a configuration option
>>>> CONFIG_MVSATA_IDE' -- why not, but it would basically be empty of
>>>> 'driving' functionality (this is handled by cmd_ide) and would only
>>>> provide initialization code, subject to board options (e.g.
>>>> CONFIG_MVSATA_IDE_ENABLE_PORT{0,1}).
>>>
>>> then you should add below initialization code in cpu.c for
>> respective SoCs
>>> and function call here
>>
>> Ok, but that means duplicating this code across SoCs aven
>> though it is
>> actually identical for all of them.
>
> That's why I initially suggested to put it as separate driver than can be used across SoCs.
> Even though it is very small code, it makes more sense creating driver for it.

Ok then, a driver it is.

Amicalement,
-- 
Albert.