[U-Boot] [PATCH] kirkwood_egiga: bugfix: add DMA sequence points

Albert ARIBAUD albert.aribaud at free.fr
Sat Jul 10 10:54:21 CEST 2010


Please disregard. I have misplaced the second isb().

> @@ -536,6 +538,9 @@ static int kwgbe_send(struct eth_device *dev, volatile void *dataptr,
>   	p_txdesc->buf_ptr = (u8 *) p;
>   	p_txdesc->byte_cnt = datasize;
>
> +	/* ensure tx desc writes above are performed before we start Tx DMA */
> +	isb();
> +
>   	/* Apply send command using zeroth TXUQ */
>   	KWGBEREG_WR(regs->tcqdp[TXUQ], (u32) p_txdesc);
>   	KWGBEREG_WR(regs->tqc, (1<<  TXUQ));

It should actually apprear right before the write to tqc.

Resending correct patch.

Amicalement,
-- 
Albert.


More information about the U-Boot mailing list