[U-Boot] [PATCH 14/28] SPEAr : Basic spear1300 architecture support added

[Wolfgang Denk]

Dear Vipin KUMAR,

In message <1279084204-3263-15-git-send-email-vipin.kumar at st.com> you wrote:
> From: Vipin KUMAR <vipin.kumar at st.com>
> 
> SPEAr1300 is an ARMCortexA9 dual core based SoC which supports
> multiple peripherals such as
...
> +	printf("System is going to reboot ...\n");
> +
> +	/*
> +	 * This 1 second delay will allow the above message
> +	 * to be printed before reset
> +	 */
> +	udelay((1000 * 1000));

udelay() is not designed to provide such long delays. This may or
may not work - it's bad style in any case.

Also, do we really need one second to print 30 characters? 

And hey, why do you print this at all?  Please remove the printf()
_and_ the delay.


...
> +/* load related definitions */
> +#define FREE_RUNNING		(0xFFFFFFFF)
> +
> +#define CONFIG_SPEARCA9_HZ_CLK	(250000000)

No parens needed in these #defines (please check and fix globally).

...
> --- /dev/null
> +++ b/arch/arm/include/asm/arch-spear13xx/sys_proto.h
> @@ -0,0 +1,34 @@

Drop that header file, and move the prototypes to some other suitable
header.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Quote from the Boss... "I didn't say it was your fault.  I said I was
going to blame it on you."