[U-Boot] [PATCH 2/2] fdt: Add fdt_node_offset_by_compat_reg helper

Jerry Van Baren gvb.uboot at gmail.com
Sun Jul 18 04:59:20 CEST 2010


Hi Kumar,

On 07/17/2010 11:49 AM, Kumar Gala wrote:
>
> On Jul 4, 2010, at 1:18 PM, Kumar Gala wrote:
>
>> Given a compatiable string and physical address try and find a node that

            compatible

>> matches.  This is useful when we want to find a specific device node to
>> update (for example if we have multiple PCI nodes we can use the
>> physical address to distinquish them when trying to update the device

                        distinguish  (s/q/g/)

>> tree).
>>
>> Signed-off-by: Kumar Gala<galak at kernel.crashing.org>
                             ^
Probably should have a space in your signed-off-by line just in case a 
SOB line parser is picky.

>> ---
>> common/fdt_support.c  |   27 +++++++++++++++++++++++++++
>> include/fdt_support.h |    2 ++
>> 2 files changed, 29 insertions(+), 0 deletions(-)
>
> Jerry,
>
> Any comments?
>
> - k

Looks OK to me other than two typos in the comment.

Acked-by: Gerald Van Baren <vanbaren at cideas.com>

gvb


More information about the U-Boot mailing list