[U-Boot] [PATCH] always relocate fdt into an lmb-allocated memory block

Jerry Van Baren gvb.uboot at gmail.com
Sun Jul 18 05:17:25 CEST 2010


Hi Timur,

On 05/24/2010 04:10 PM, Timur Tabi wrote:
> The device tree (fdt) must always exist in within the bootmap (usually the
> first 16MB of RAM).  If it doesn't, then boot_relocate_fdt() will allocate an
> LMB region in the bootmap and copy the fdt into that region.  It will also
> increase the size of the fdt.
>
> If the fdt is already in the bootmap, then previously the memory was just
> reserved.  There was no contingency if the reservation failed, however.
>
> By always allocating an lmb region and copying/resizing the fdt into that
> region, the code is simplified and the memory region is always allocated
> properly.
>
> Also change the types of some variables to avoid some typecasts.
>
> Signed-off-by: Timur Tabi<timur at freescale.com>
                            ^
Need a space in your SOB line?

> ---
>   common/image.c |   83 +++++++++++++++++++-------------------------------------
>   1 files changed, 28 insertions(+), 55 deletions(-)

I assume this is a "live" patch, and replaces the patch with the subject 
"libfdt: make fdt_increase_size() available to	everyone".  It looks like 
a good improvement to me and nobody threw any stones at it, so...

Acked-by: Gerald Van Baren <vanbaren at cideas.com>

[snip]

Best regards,
gvb


More information about the U-Boot mailing list