[U-Boot] [PATCH] net, fec: fix "Warning: eth device name has a space!" for FEC devices

Ben Warren biggerbadderben at gmail.com
Mon Jul 19 21:24:28 CEST 2010


  Hi Stefano,

On 7/19/2010 12:11 PM, Stefano Babic wrote:
> Wolfgang Denk wrote:
>
>> I always wondered why we need such a long (and slow to type) name. I
>> suggest we use this opportunity and change the name into a plain and
>> simple "FEC" resp. "SCC" and "FCC" ?
> Then probably unify the rule even for other architectures. We have a
> "FEC_MXC", too, for Freescale's i.MX processors. We can use "FEC_PPC",
> "SCC_PPC" if we want to add the architecture name (I do not think is
> useful), or better set the name to "FEC" for fec_mxc.c, too.
>
> Best regards,
> Stefano Babic
>
Unless you have a chip with both MXC and PPC FECs, which I doubt, I 
don't think the extra namespace buys anything.  Saving a few keystrokes, 
on the other hand (no pun intended) is a good thing.

regards,
Ben


More information about the U-Boot mailing list