[U-Boot] [PATCH V5 4/4] edminiv2: add mvsata_ide and cmd_ide support

[Albert ARIBAUD]

Hi Prafulla et al.,

Le 21/07/2010 12:26, Prafulla Wadaskar a écrit :

>> +#define __io
>> +
>
> Pls move this below inside #ifdef CONFIG_CMD_IDE

Wilco.

>> +#define CONFIG_CMD_IDE
>> +#define CONFIG_DOS_PARTITION
>> +#define CONFIG_CMD_EXT2
>
> It's good if you use #ifdef here and pull all IDE specific configuration in it
> I had already provided same comment for previous patch

You're right--I thought I'd done it but failed to cherry-pick it into V5.

> Secondly I tried to generate similar patches for Kirkwood oneprd_base (attached) on the top of this patch series
> But somehow "ide reset" is unable to detect device on port.
> If you have openrd_base board, can you pls give a try?
 >
 > May be you may need to look at mpp config.

I have an OpenRD Client, not base; client has a SATA connector to which 
I have a disk connected, so I could give it a try but we'll need to make 
sur how many SATA ports kirkwood has and which ones are used on either 
openrd client and base (orion5x has two sata ports and edmini uses port 
1, not 0, for its sole SATA conector). I am away from home right now, 
but I will be able to give it a try as soon as August 1st.

> Regards..
> Prafulla . .

Amicalement,
-- 
Albert.