[U-Boot] [PATCH 1/5] usb_storage.c: initialize device type
Wolfgang Denk
wd at denx.de
Sat Jul 24 20:46:26 CEST 2010
Dear Wolfgang Denk,
In message <1279532220-5848-2-git-send-email-wd at denx.de> you wrote:
> The device type was left uninitialized which caused later tests
> against DEV_TYPE_UNKNOWN to fail. In the result, "usb part" would
> attempt to print information about non-existent devices like this:
>
> => usb part
> print_part of 0
>
> Partition Map for USB device 0 -- Partition Type: DOS
>
> Partition Start Sector Num Sectors Type
> 1 0 2031616 f8
>
> print_part of 1
> ## Unknown partition table
>
> print_part of 2
> ## Unknown partition table
>
> print_part of 3
> ## Unknown partition table
>
> print_part of 4
> ## Unknown partition table
> =>
>
> By initializing the type as DEV_TYPE_UNKNOWN we avoid all the
> "Unknown partition table" messages.
>
> [Note: the "print_part of ?" messages is left over debug code that
> will be removed in another patch.]
>
> Signed-off-by: Wolfgang Denk <wd at denx.de>
> Cc: Remy Bohmer <linux at bohmer.net>
>
> ---
> common/usb_storage.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
Applied.
Remy, I hope this is OK with you?
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
All your people must learn before you can reach for the stars.
-- Kirk, "The Gamesters of Triskelion", stardate 3259.2
More information about the U-Boot
mailing list